lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 7/9] clk: tegra: add clock support for tegra30
On 01/11/2013 05:17 AM, Hiroshi Doyu wrote:
> On Fri, 11 Jan 2013 08:46:25 +0100
> Prashant Gaikwad <pgaikwad@nvidia.com> wrote:
>
>> Add tegra30 clock support based on common clock framework.
>>
>> Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> .......
>> +static void __init tegra30_pll_init(void)
>> +{
>> + struct clk *clk;
>> +
>> + /* PLLC */
>> + clk = tegra_clk_pll("pll_c", "pll_ref", clk_base, pmc_base, 0,
>> + 0, &pll_c_params,
>> + TEGRA_PLL_HAS_CPCON | TEGRA_PLL_USE_LOCK,
>> + pll_c_freq_table, NULL);
>> + clk_register_clkdev(clk, "pll_c", NULL);
>> + clks[pll_c] = clk;
>
> Just I noticed that there are quite many same itegration of:
>
> clk_register_clkdev(clk, <ID name>, ?);
> clks[<ID>] = clk;
>
> ID == <ID name>
>
> Can any macro/func do the above at once?

To my mind, a macro would obfuscate this fairly simple code, unless
there is a table somewhere the maps <ID> to <ID name> which would allow
saving some code space (I just looked; I don't think there is).
Eventually (later cleanup), I wouldn't be surprised if both parameters
to clk_register_clkdev() became NULL in most cases, since most lookups
are through DT by the end of this series.


\
 
 \ /
  Last update: 2013-01-11 23:21    [W:0.221 / U:2.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site