lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend 2/2] Input: twl6040-vibra: Code cleanup in probe with devm_* conversion
Hi Dmitry,

On 01/10/2013 06:54 PM, Dmitry Torokhov wrote:
> Hi Peter,
>
> On Thu, Jan 10, 2013 at 02:36:05PM +0100, Peter Ujfalusi wrote:
>> Convert the probe to use devm_*. At the same time reorder the calls
>> so we will register the input device as the last step when the driver
>> is loaded.
>
> If you are doing this please also use devm_input_allocate_device() and
> devm_regulator_bulk_get().

Now I remember: I can not switch to devm_regulator_bulk_get() unfortunately
since when we boot with DT the code needs to reach up for the parent's dev to
get the needed regulator. If I use devm_regulator_bulk_get() the resource will
be bind to the parent dev and not to the vibra driver.

> I also think it is high time to get rid of
> dedicated work queue - cwq hasn't actually given you a separate therad
> for a while now and if you get rid of workqueue you can get ridof entire
> twl6040_vibra_remove().

I agree with the rest. I'll move both twl4030/6040 vibra to use
devm_input_allocate_device() and also I will move them to use system wide
workqueue.

I'm going to resend the series soon with the suggested changes.

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-11 11:01    [W:0.072 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site