lkml.org 
[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool support
From
From: Byungho An <bh74.an@samsung.com>
Date: Thu, 10 Jan 2013 15:54:24 -0800

> @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev,
>
> if (phy->autoneg) {
> if (netif_running(netdev))
> + if((interface == PHY_INTERFACE_MODE_SGMII) ||
> + (interface == PHY_INTERFACE_MODE_TBI) ||
> + (interface == PHY_INTERFACE_MODE_RTBI))
> + priv->hw->mac->set_autoneg(priv->ioaddr);

This is still not properly formatted.

You also didn't submit this properly. Never use email thread replies
to submit new versions of patches.

Always use fresh, new, mailing list postings to submit new versions
of patches.

Also, when one patch has to change in a series, you must reubmit
the entire set of patches even if some of them have no changes
at all. I do not see patch #2 here at all.


\
 
 \ /
  Last update: 2013-01-11 02:21    [W:0.051 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site