Messages in this thread | | | Date | Thu, 10 Jan 2013 14:38:35 -0800 (PST) | Subject | Re: [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE | From | David Miller <> |
| |
From: Stefan Hajnoczi <stefanha@redhat.com> Date: Thu, 10 Jan 2013 12:55:03 +0100
> On Thu, Jan 10, 2013 at 01:31:08PM +0200, Michael S. Tsirkin wrote: >> At the moment, we check owner when we enable queue in tun. >> This seems redundant and will break some valid uses >> where fd is passed around: I think TUNSETOWNER is there >> to prevent others from attaching to a persistent device not >> owned by them. Here the fd is already attached, >> enabling/disabling queue is more like read/write. >> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> >> --- >> >> Note: this is unrelated to Stefan's bugfix. > > This should go into 3.8-rc. > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied.
| |