lkml.org 
[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool support
    From
    From: Byungho An <bh74.an@samsung.com>
    Date: Tue, 08 Jan 2013 15:32:02 -0800

    > @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev,
    >
    > if (phy->autoneg) {
    > if (netif_running(netdev))
    > + if((interface == PHY_INTERFACE_MODE_SGMII) ||
    > + (interface == PHY_INTERFACE_MODE_TBI) ||
    > + (interface == PHY_INTERFACE_MODE_RTBI))
    > + priv->hw->mac->set_autoneg(priv->ioaddr);

    This is improperly indented and formatted, use this style:

    if (A ||
    B ||
    C)
    statement();

    I can tell what you're trying to do, you are just trying to use TAB
    characters exclusivly to indent because you are lazy. But that's not
    the objective here.


    \
     
     \ /
      Last update: 2013-01-10 09:43    [W:2.845 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site