Messages in this thread | | | Date | Thu, 10 Jan 2013 16:46:49 +0100 | Subject | Re: [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec | From | Sedat Dilek <> |
| |
On Wed, Jan 9, 2013 at 8:58 PM, Dave Kleikamp <dave.kleikamp@oracle.com> wrote: > This patchset was begun by Zach Brown and was originally submitted for > review in October, 2009. Feedback was positive, and I have picked up > where he left off, porting his patches to the latest mainline kernel > and adding support more file systems. > > This patch series adds a kernel interface to fs/aio.c so that kernel code can > issue concurrent asynchronous IO to file systems. It adds an aio command and > file system methods which specify io memory with pages instead of userspace > addresses. > > This series was written to reduce the current overhead loop imposes by > performing synchronus buffered file system IO from a kernel thread. These > patches turn loop into a light weight layer that translates bios into iocbs. > > It introduces new file ops, read_iter() and write_iter(), that replace the > aio_read() and aio_write() operations. The iov_iter structure can now contain > either a user-space iovec or a kernel-space bio_vec. Since it would be > overly complicated to replace every instance of aio_read() and aio_write(), > the old operations are not removed, but file systems implementing the new > ones need not keep the old ones. > > Changes from V4 include: > * moved iov-iter.c from mm/ to fs/ > * removed dio_aligned helper > * insured that FUA write to loop device is committed to media > * removed no-longer-used REQ_KERNEL define > > These patches apply to 3.8-rc2 and are also available at: > git://github.com/kleikamp/linux-shaggy.git loop_2013_01_04 > > My hopes are that this patchset is finally ready for linux-next. >
Hi Dave,
I am using here Ubuntu/precise AMD64 as a WUBI-installed system.
Not sure if WUBI [1] is a good test-candidate.
[ /boot/grub/grub.cfg ] ... set root=(loop0) linux /boot/vmlinuz-3.8.0-rc2-9-iniza-generic root=UUID=001AADA61AAD9964 loop=/ubuntu/disks/root.disk ro ...
Poops, I did it (not again) but for the first time to test your loop-patchset on top of Linux v3.8-rc2 plus some important other stuff (see patches/ dir in attached tarball).
As I did not know how to test it in a meaningful way I just run the "lite" test-script from LTP [2]. Please, have a look at the ERRORs and failures.
$ egrep -i 'error|fail' for-dkleikamp/tests/runltplite-results_loop-experimental.txt | grep -v -i expected | wc -l 210
In good old German tradition I have collected some interesting stuff in the attached tarball ;-). If something is missing - blame me. Don't hesitate to ask (I have your patchset for a while on my radar).
Thanks!
Regards, - Sedat -
[1] https://wiki.ubuntu.com/WubiGuide [2] http://sourceforge.net/projects/ltp/
P.S.: Output of ls -lR for-dkleikamp/
$ cat for-dkleikamp/ls-lR.txt .: total 20 drwxrwxr-x 2 wearefam wearefam 4096 Jan 10 16:26 configs drwxrwxr-x 2 wearefam wearefam 4096 Jan 10 16:27 hwinfos drwxrwxr-x 2 wearefam wearefam 4096 Jan 10 16:27 logs -rw-rw-r-- 1 wearefam wearefam 0 Jan 10 16:28 ls-lR.txt drwxrwxr-x 2 wearefam wearefam 4096 Jan 10 16:28 patches drwxrwxr-x 2 wearefam wearefam 4096 Jan 10 16:27 tests
./configs: total 108 -rw-r--r-- 1 wearefam wearefam 108343 Jan 10 11:55 config-3.8.0-rc2-9-iniza-generic
./hwinfos: total 28 -rw-rw-r-- 1 wearefam wearefam 24708 Jan 10 16:26 lspci-nnvv.txt
./logs: total 240 -rw-rw-r-- 1 wearefam wearefam 125024 Jan 10 11:55 deb-pkg.log -rw-rw-r-- 1 wearefam wearefam 52973 Jan 10 11:59 dmesg_3.8.0-rc2-9-iniza-generic.txt -rw-rw-r-- 1 wearefam wearefam 58279 Jan 10 12:00 dmesg_3.8.0-rc2-9-iniza-generic_after-suspend-resume.txt
./patches: total 200 -rw-rw-r-- 1 wearefam wearefam 203752 Jan 10 11:42 3.8.0-rc2-9-iniza-generic.patch
./tests: total 608 -rw-rw-r-- 1 wearefam wearefam 618423 Jan 10 15:10 runltplite-results_loop-experimental.txt [unhandled content-type:application/octet-stream][unhandled content-type:application/octet-stream] | |