[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7u1 20/31] x86, kexec: replace ident_mapping_init and init_level4_page
On Wed, Jan 09, 2013 at 05:26:18PM -0800, Yinghai Lu wrote:
> I should say:
> that *is* initialized to false by default.
> please check

Ok, I didn't know that, thanks for pointing it out.

And yet, this is not the point - the point is that this code is
complicated enough as it is so why not make the easy things trivial so
that people looking at it months or even years from now can still try to
understand it.

So what it is defined by the standard?! Just add that line anyway! Then
there's no need to go check what was meant. This way it is *there*,
*explicit* and everyone *knows* what is meant - even people who don't
sleep with C99std under their pillow.

It is not like we're saving code since the mov $0 gets issued by the
compiler anyway when it is on the stack:

movq $0, -48(%rbp) #, info
movq $0, -40(%rbp) #, info
movq $0, -32(%rbp) #, info
movq $0, -24(%rbp) #, info



Sent from a fat crate under my desk. Formatting is fine.

 \ /
  Last update: 2013-01-10 13:41    [W:0.134 / U:7.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site