lkml.org 
[lkml]   [2012]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7 V6] workqueue: fix idle worker depletion
Hello, Lai.

On Sun, Sep 09, 2012 at 12:09:58PM +0800, Lai Jiangshan wrote:
> > mutex_lock(&pool->manager_mutex);
> > if (worker_maybe_bind_and_lock(worker))
> > worker_clr_flags(worker, WORKER_UNBOUND);
> > ret = true;
> >
>
>
> This code is correct. worker_maybe_bind_and_lock() can be called any time.
> but I like to call it only when it is really needed.

Ummm... that code is complex for no reason. It isn't easier to read
or better in any way. Given the recent exchanges, it seems our tastes
differ greatly. Can you please just refresh the two patches as
requested and repost them on top of for-3.6-fixes?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-09-09 09:22    [W:0.081 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site