lkml.org 
[lkml]   [2012]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 84/95] virtio_blk: fix config handler race
On 09/10/2012 10:26 AM, Rusty Russell wrote:
> Ben Hutchings <ben@decadent.org.uk> writes:
>
>> 3.2-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: "Michael S. Tsirkin" <mst@redhat.com>
>>
>> commit 4678d6f970c2f7c0cbfefc0cc666432d153b321b upstream.
>>
>> Fix a theoretical race related to config work
>
> ???
>
> From Documentation/stable_kernel_rules.txt:
>
> - No "theoretical race condition" issues, unless an explanation of how the
> race can be exploited is also provided.
>
> Similarly, '[ 85/95] virtio_blk: Drop unused request tracking list'
> is a marginal perf improvement, why is it in there?

This also drops the following line which may trigger a BUG in hot
-unplug path.

/* Nothing should be pending. */
BUG_ON(!list_empty(&vblk->reqs));

So, this patch is needed to fix up the hot-unplug bug along with the others.

>
> Neither of these were cc:stable; did someone request them specifically?
>
> Confused,
> Rusty.
>


--
Asias


\
 
 \ /
  Last update: 2012-09-10 05:21    [W:0.168 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site