[lkml]   [2012]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH 0/7] uprobes: single-step fixes
On 09/03, Oleg Nesterov wrote:
> Sebastian, I changed your patches a bit:
> 1/7:
> - Change the subject and update the changelog. In particular,
> s/utrace/uprobes/. I am wondering where this typo came from ;)

Hmm. I just noticed this patch is buggy. arch_uprobe_disable_step(&uprobe->arch)
is not safe after put_uprobe().

Srikar, I fixed this in my tree with the following change,

--- kernel/events/uprobes.c~ 2012-09-02 16:52:54.000000000 +0200
+++ kernel/events/uprobes.c 2012-09-08 18:56:44.000000000 +0200
@@ -1536,10 +1536,10 @@ static void handle_singlestep(struct upr

+ arch_uprobe_disable_step(&uprobe->arch);
utask->active_uprobe = NULL;
utask->state = UTASK_RUNNING;
- arch_uprobe_disable_step(&uprobe->arch);


I hope your ack is still valid.

And this also allows us to rely on utask->state in disable_step(), see
the new 8/7 I'll send in a minute. I was going to fix this later, but
I just realized that "disable if trapped" is more buggy than I thought.

Assuming that you are agree with 6 and 8. I'd prefer the new one as a
separate change, but if you prefer to join them please let me know.


 \ /
  Last update: 2012-09-08 19:41    [W:0.188 / U:0.064 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site