lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] DMA mapping error check analysis
From
Date
On Fri, 2012-09-07 at 12:20 -0400, Alan Stern wrote:
> On Fri, 7 Sep 2012, Shuah Khan wrote:
>
> > I analyzed all calls to dma_map_single() and dma_map_page() in the
> > kernel, to see if callers check for mapping errors, before using the
> > returned address.
> >
> > The goal of this analysis is to find drivers that currently do not
> > check dma mapping errors, and fix them.
> >
> > I documented the results of this analysis:
> >
> > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis
> >
> > Please review and give me feedback on the analysis and the proposed
> > next steps.
>
> Your first table (dma_map_single) lists drivers/usb/core/usb.c and
> marks it as Bad. This is a mistake because the code is #ifdef'ed out.
> It hasn't been used in many years; it should be removed.

Thanks for catching it. I did note that in my research notes and that
was left out by mistake when I put the table together. Table is updated
now with your comment and marked it a Cleanup item.

-- Shuah



\
 
 \ /
  Last update: 2012-09-07 19:41    [W:0.103 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site