lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] uprobes: Do not (ab)use TIF_SINGLESTEP/user_*_single_step() for single-stepping
On 09/07, Srikar Dronamraju wrote:
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Thanks!

(and thanks, I'll fix the typo in 2/7 you pointed out)

> > void arch_uprobe_enable_step(struct arch_uprobe *auprobe)
> > {
> > - struct uprobe_task *utask = current->utask;
> > - struct arch_uprobe_task *autask = &utask->autask;
> > + struct task_struct *task = current;
>
> Any particular reason to use task instead of current?

No particular reason, and I think in this case asm will be the same.

Please let me know if you prefer to remove this variable, I'll redo
this patch.

Oleg.



\
 
 \ /
  Last update: 2012-09-07 18:41    [W:0.063 / U:10.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site