lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH tip/core/rcu 03/23] rcu: Move RCU grace-period cleanup into kthread
On Thu, Sep 06, 2012 at 03:34:38PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-08-30 at 11:18 -0700, Paul E. McKenney wrote:
> > static void rcu_report_qs_rsp(struct rcu_state *rsp, unsigned long flags)
> > __releases(rcu_get_root(rsp)->lock)
> > {
> > + raw_spin_unlock_irqrestore(&rcu_get_root(rsp)->lock, flags);
> > + wake_up(&rsp->gp_wq); /* Memory barrier implied by wake_up() path. */
> > }
>
> Could you now also clean up the locking so that the caller releases this
> lock?
>
> I so dislike asymmetric locking like that..

Or I could inline the whole thing at the two callsites...

Thanx, Paul



\
 
 \ /
  Last update: 2012-09-07 09:01    [W:0.128 / U:55.108 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site