| Date | Fri, 7 Sep 2012 11:30:29 +0900 | Subject | Re: [PATCH] staging/rts_pstor: remove braces {} in sd.c | From | Toshiaki Yamane <> |
| |
On Wed, Sep 5, 2012 at 4:30 AM, Greg Kroah-Hartman <greg@kroah.com> wrote: > On Sat, Sep 01, 2012 at 10:43:00PM +0900, Toshiaki Yamane wrote: >> fixed below checkpatch warnings. >> -WARNING: braces {} are not necessary for single statement blocks >> -WARNING: braces {} are not necessary for any arm of this statement >> >> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> >> --- >> drivers/staging/rts_pstor/sd.c | 1112 +++++++++++++++++----------------------- >> 1 file changed, 469 insertions(+), 643 deletions(-) > > Why is the object file size changing with this patch applied? That > implies that something went wrong with your patch, care to redo it in a > format that I can properly review it?
I had to remove the brace that I must not be deleted. I will send a patch later.
@@ -2729,15 +2644,13 @@ static int mmc_test_switch_bus(struct | @@ -2729,9 +2611,8 @@ static int mmc_test_switch_bus(struct r rtsx_add_cmd(chip, CHECK_REG_CMD, REG_SD_TRANSFER, SD rtsx_add_cmd(chip, CHECK_REG_CMD, REG_SD_TRANSFER, SD
rtsx_add_cmd(chip, READ_REG_CMD, PPBUF_BASE2, 0, 0); rtsx_add_cmd(chip, READ_REG_CMD, PPBUF_BASE2, 0, 0); - if (width == MMC_8BIT_BUS) { - if (width == MMC_8BIT_BUS) { + if (width == MMC_8BIT_BUS) + if (width == MMC_8BIT_BUS) rtsx_add_cmd(chip, READ_REG_CMD, PPBUF_BASE2 rtsx_add_cmd(chip, READ_REG_CMD, PPBUF_BASE2 - } - }
retval = rtsx_send_cmd(chip, SD_CARD, 100); retval = rtsx_send_cmd(chip, SD_CARD, 100); - if (retval < 0) { | if (retval < 0) { + if (retval < 0) | @@ -2747,15 +2628,14 @@ static int mmc_test_switch_bus(struct rtsx_clear_sd_error(chip); < TRACE_RET(chip, SWITCH_ERR); < - } < < ptr = rtsx_get_cmd_data(chip) + 1; < < @@ -2747,15 +2660,15 @@ static int mmc_test_switch_bus(struct <
|