lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] [powerpc] Change memory_limit from phys_addr_t to unsigned long long
From
Date
On Tue, 2012-08-21 at 17:12 +0530, Suzuki K. Poulose wrote:
> There are some device-tree nodes, whose values are of type phys_addr_t.
> The phys_addr_t is variable sized based on the CONFIG_PHSY_T_64BIT.
>
> Change these to a fixed unsigned long long for consistency.
>
> This patch does the change only for memory_limit.
>
> The following is a list of such variables which need the change:
>
> 1) kernel_end, crashk_size - in arch/powerpc/kernel/machine_kexec.c
>
> 2) (struct resource *)crashk_res.start - We could export a local static
> variable from machine_kexec.c.
>
> Changing the above values might break the kexec-tools. So, I will
> fix kexec-tools first to handle the different sized values and then change
> the above.
>
> Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
> ---

Breaks the build on some configs (with 32-bit phys_addr_t):

/home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c: In function
'early_init_devtree':
/home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c:664:25: error:
comparison of distinct pointer types lacks a cast

I'm fixing that myself this time but please be more careful.

Cheers,
Ben.




\
 
 \ /
  Last update: 2012-09-07 04:21    [W:0.206 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site