Messages in this thread | | | From | Michal Nazarewicz <> | Subject | Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list | Date | Thu, 06 Sep 2012 14:56:45 +0200 |
| |
>> + pfn = page_to_pfn(page); >> + if (pfn >= end_pfn) >> + return false; >> + if (pfn >= start_pfn) >> + goto found;
On Thu, Sep 06 2012, Lai Jiangshan wrote: > this test is wrong. > > use this: > > if ((pfn <= start_pfn) && (start_pfn < pfn + (1UL << page_order(page)))) > goto found; > > if (pfn > start_pfn) > return false;
if (pfn > start_pfn) return false; if (pfn + (1UL << page_order(page)) > start_pfn) goto found;
>> + } >> + return false; >> + >> + list_for_each_entry_continue(page, &isolated_pages, lru) { >> + if (page_to_pfn(page) != next_pfn) >> + return false;
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--[unhandled content-type:application/pgp-signature] | |