lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/11 V5] workqueue: Add @bind arguement back without change any thing
Hello, Lai.

On Thu, Sep 06, 2012 at 09:04:06AM +0800, Lai Jiangshan wrote:
> > This doesn't change anything. You're just moving the test to the
> > caller with comments there explaining how it won't change even if
> > gcwq->lock is released. It seems more confusing to me. The flag is
> > still protected by manager_mutex. How is this an improvement?
> >
>
> Some other bit of gcwq->flags is accessed(modified) without manager_mutex.
> making gcwq->flags be accessed only form gcwq->lock C.S. will help the reviewer.
>
> I don't like adding special things/code when not-absolutely-required.

I really fail to see this. The flag has to stay stable while
manage_mutex is held no matter where you test it. It doesn't make any
it any more readable whether you test it inside gcwq->lock with the
comment saying "this won't change while manager_mutex is held" or just
test it while manager_mutex is held. It is a synchronization oddity
no matter what and as long as it's well documented, I don't really see
the point in the change.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-09-06 19:42    [W:3.694 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site