lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15
From
On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> chained_irq_enter/exit() already mask&ack/unmask the chained interrupt.
> There is no need to also explicitly do it in the handler.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> arch/arm/mach-exynos/common.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 4eb39cd..0a85aec 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq, struct irq_desc *desc)
> struct irq_chip *chip = irq_get_chip(irq);
>
> chained_irq_enter(chip, desc);
> - chip->irq_mask(&desc->irq_data);
> -
> - if (chip->irq_ack)
> - chip->irq_ack(&desc->irq_data);
> -
> generic_handle_irq(*irq_data);
> -
> - chip->irq_unmask(&desc->irq_data);
> chained_irq_exit(chip, desc);
> }
>
> --
> 1.7.7.3
>

Acked-by: Doug Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2012-09-06 18:21    [W:0.099 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site