Messages in this thread | | | Date | Thu, 6 Sep 2012 11:36:06 -0400 | Subject | Re: Check all returns from audit_log_start | From | Eric Paris <> |
| |
On Thu, Sep 6, 2012 at 11:08 AM, Dave Jones <davej@redhat.com> wrote: > Following on from the previous patch that fixed an oops, these > are all the other similar code patterns in the tree with the same > checks added. I never saw these causing problems, but checking > this everywhere seems to make more sense than every subsequent > routine that gets passed 'ab' having to check it. > > Later we could remove all those same checks from audit_log_format > and friends. For now, this just prevents similar bugs being introduced > as the one in my previous patch. > > Signed-off-by: Dave Jones <davej@redhat.com>
Not certain because I haven't looked at what happens with the error code, but I think this might not be right. auditd can be explictly told not to audit certain events, in which case it is normal and expected that ab would come back NULL....
| |