Messages in this thread | | | Date | Thu, 6 Sep 2012 12:33:13 +0200 | From | Kurt Van Dijck <> | Subject | Re: [PATCH can-next v6] can: add tx/rx LED trigger support |
| |
On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote: > On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote: > > On Mon, Sep 03, 2012 at 10:54:49PM +0200, Oliver Hartkopp wrote: > > > On 03.09.2012 20:29, Fabio Baltieri wrote: > > > > > > [...] > > > The name of the device can only be changed when the interface is down. > > > Is it possible to put some scripting around it to detach and attach the leds > > > to the interfaces on ifup/ifdown triggers? > > > > Are the led triggers available for using while the netdev is down then? > > Sure! On embedded systems triggers are usually attached to actual LEDs > at probe time using default_trigger field of struct led_classdev, and > that can be specified both in machine files or in device tree.
I also think that led triggers should be available. I asked the question because detach & attach leds to interfaces would indeed break that.
btw, I tried to send a patch tuesday (my first $ git send-email) using netdev notifiers: did you receive it, and what do you think of it?
Kurt
| |