Messages in this thread Patch in this message | | | From | Ian Abbott <> | Subject | [PATCH] UDF: Fix incorrect error handling in udf_direct_IO() | Date | Thu, 6 Sep 2012 11:08:11 +0100 |
| |
My recent patch to add DIRECT_IO support to the UDF filesystem handler contains a mistake in the error recovery if blockdev_direct_IO() fails. The test `rw && WRITE` should be `rw & WRITE`. Fix it.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk> --- fs/udf/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index b905448..41d5830 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -156,7 +156,7 @@ static ssize_t udf_direct_IO(int rw, struct kiocb *iocb, ret = blockdev_direct_IO(rw, iocb, inode, iov, offset, nr_segs, udf_get_block); - if (unlikely(ret < 0 && (rw && WRITE))) + if (unlikely(ret < 0 && (rw & WRITE))) udf_write_failed(mapping, offset + iov_length(iov, nr_segs)); return ret; } -- 1.7.12
| |