Messages in this thread | | | Date | Thu, 6 Sep 2012 10:46:19 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v2] powerpc: fix personality handling in ppc64_personality() |
| |
On Thu, 6 Sep 2012, Benjamin Herrenschmidt wrote:
> > actually commit 7256a5d2da56 seems to contain the correct PER_LINUX > > handling, so seems like you picked the right one :) > > > > Odd, they looked different around the use of PER_MASK when I looked but
The original patch had
personality &= ~PER_LINUX | PER_LINUX32;
Which is bogus, exactly because ~PER_LINUX is -1.
I then used
personality = (personality & ~PER_MASK) | PER_LINUX32;
which is correct and perhaps a little bit more descriptive, and that is what you have merged, so all is fine.
> I was tired & jet lagged, so I might have just had a brain fail...
Probably just missed that the first patch used PER_LINUX and the second one PER_MASK, or whatever.
Anyway, thanks.
-- Jiri Kosina SUSE Labs
| |