Messages in this thread | | | Subject | Re: [PATCH 2/3] x86/mce: Pack boolean MCE flags into a structure | From | Joe Perches <> | Date | Wed, 05 Sep 2012 10:15:22 -0700 |
| |
On Wed, 2012-09-05 at 15:52 +0530, Naveen N. Rao wrote: > Many MCE flags are boolean in nature, but are declared as integers > currently. We can pack these into a bitfield to save some space. [] > diff --git a/arch/x86/kernel/cpu/mcheck/mce-internal.h b/arch/x86/kernel/cpu/mcheck/mce-internal.h [] > @@ -11,6 +11,15 @@ enum severity_level { > MCE_PANIC_SEVERITY, > }; > > +struct mce_config { > + __u32 cmci_disabled : 1, > + ignore_ce : 1, > + dont_log_ce : 1, > + __pad : 29;
You don't need to declare __pad Perhaps bool:1 instead.
| |