Messages in this thread | | | Date | Tue, 4 Sep 2012 15:41:43 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed |
| |
On Tue, 4 Sep 2012 17:22:15 +0800 yan yan <clouds.yan@gmail.com> wrote:
> 2012/9/4 Cong Wang <xiyou.wangcong@gmail.com>: > > On 09/03/2012 10:14 PM, yan wrote: > >> > >> Signed-off-by: yan <clouds.yan@gmail.com> > > > > > > Please provide a changelog to explain why we need this patch. > > I think the title is self explained.
Given this review feedback, the title alone was obviously insufficient!
I provided the following changelog text:
: If proc_get_inode() returns NULL then presumably it encountered memory : exhaustion. proc_lookup_de() should return -ENOMEM in this case, not : -EINVAL.
| |