Messages in this thread | | | Subject | Re: [PATCH] ACPI: Enable SCI_EMULATE to manually simulate physical hotplug testing. | From | Toshi Kani <> | Date | Tue, 04 Sep 2012 15:54:21 -0600 |
| |
On Tue, 2012-09-04 at 14:46 -0700, Yinghai Lu wrote: > On Tue, Sep 4, 2012 at 2:34 PM, Toshi Kani <toshi.kani@hp.com> wrote: > > On Tue, 2012-09-04 at 12:17 -0700, Yinghai Lu wrote: > > - If a full path is specified in acpi_name, it ignores the arg hsb > > ("\_SB"). > > - If a relative path is specified in acpi_name, it appends the arg hsb. > > > > So, the code looks good to me; assuming that is the intent. > > > > However, the error message below will show up like "\_SB.\_SB.PCIB" when > > a full path is specified. > > I always use > echo "\_SB.PCIB 3" > /sys/kernel/debug/acpi/sci_notify > > and it works. > > so assume that function can accept \_SB.PCIB and PCIB both.
I agree. And that's what I tried to say.
The error message below will be confusing when a (invalid) full path name is specified, though.
>> + if (ACPI_FAILURE(status) || ACPI_FAILURE(status1)) { >> + pr_err(PREFIX >> + "acpi getting handle to <\\_SB.%s> failed inside notify_client \n", >> + acpi_name); >> + return; >> + }
Thanks, -Toshi
| |