Messages in this thread | | | Date | Tue, 4 Sep 2012 18:58:47 +0200 | Subject | Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation | From | Sjur Brændeland <> |
| |
Hi Michael,
> Exactly. Though if we just fail load it will be much less code. > > Generally, using a feature bit for this is a bit of a problem though: > normally driver is expected to be able to simply ignore > a feature bit. In this case driver is required to > do something so a feature bit is not a good fit. > I am not sure what the right thing to do is.
I see - so in order to avoid the binding between driver and device there are two options I guess. Either make virtio_dev_match() or virtcons_probe() fail. Neither of them seems like the obvious choice.
Maybe adding a check for VIRTIO_CONSOLE_F_DMA_MEM match between device and driver in virtcons_probe() is the lesser evil?
Regards, Sjur
| |