Messages in this thread | | | Date | Tue, 4 Sep 2012 11:13:30 -0500 | From | Kent Yoder <> | Subject | Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces |
| |
On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote: > Sparse finds that bug as well. ;) > > drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment (different address spaces) > drivers/acpi/acpica/tbfadt.c:247:15: expected struct acpi_table_header *table > drivers/acpi/acpica/tbfadt.c:247:15: got void [noderef] <asn:2>* > drivers/acpi/acpica/tbfadt.c:266:30: warning: incorrect type in argument 1 (different address spaces) > drivers/acpi/acpica/tbfadt.c:266:30: expected void [noderef] <asn:2>*logical_address > drivers/acpi/acpica/tbfadt.c:266:30: got struct acpi_table_header *table > > It should be memcpy_fromio() probably.
Thanks Dan, that's clearly better. James, I'll resubmit this one today.
Thanks, Kent
| |