lkml.org 
[lkml]   [2012]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 080/262] usb: gadget: dummy_hcd: fixup error probe path
On Sat, Sep 29, 2012 at 09:01:15PM +0200, Ben Hutchings wrote:
> > This is a problem since 448b6eb1 ("USB: Make sure to fetch the BOS desc
> > for roothubs.) if used in USB3 mode because dummy does not provide this
> > descriptor and explodes later.
> [...]
>
> i.e. for 3.5 (as noted in the cc: stable line). But I don't see why
> this isn't needed for earlier kernel versions. The same broken error
> handling is present.

Hmmm. The error handling is broken since day 1 that is cdfcbd2c4a ("usb:
gadget: dummy_hcd: use the shared_hcd infrastructure") / v3.1-rc1.
Prior v3.5 it is unlikely that something fails here, I never noticed it.
However you are right: wrong is wrong and thefore it should be picked up to
v3.1.

> Ben.

Sebastian


\
 
 \ /
  Last update: 2012-09-30 15:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog