Messages in this thread | | | Subject | Re: [PATCH] extcon: adc-jack: Fix checking return value of request_any_context_irq | From | anish kumar <> | Date | Sun, 30 Sep 2012 09:37:29 +0530 |
| |
On Fri, 2012-09-28 at 07:36 +0800, Axel Lin wrote: > On failure, request_any_context_irq() returns a negative value. > On success, it returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED. > > Also ensure adc_jack_probe() return 0 on success. this patch makes sense. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/extcon/extcon-adc-jack.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c > index 725eb5a..2cc6bec 100644 > --- a/drivers/extcon/extcon-adc-jack.c > +++ b/drivers/extcon/extcon-adc-jack.c > @@ -161,13 +161,12 @@ static int __devinit adc_jack_probe(struct platform_device *pdev) > err = request_any_context_irq(data->irq, adc_jack_irq_thread, > pdata->irq_flags, pdata->name, data); > > - if (err) { > + if (err < 0) { > dev_err(&pdev->dev, "error: irq %d\n", data->irq); > - err = -EINVAL; > goto err_irq; > } > > - goto out; > + return 0; > > err_irq: > extcon_dev_unregister(&data->edev);
| |