Messages in this thread | | | Date | Mon, 3 Sep 2012 21:57:00 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] Remove bogus memcpy in brcm80211 ai_detach |
| |
On Mon, Sep 03, 2012 at 02:22:48PM -0500, Larry Finger wrote: > On 09/03/2012 02:13 PM, Andi Kleen wrote: > >gcc 4.8 warns for this memcpy. While the copy size is correct, the whole > >copy seems to be a nop because the destination is never used, and > >there's no need to use memcpy to copy pointers anyways. And the > >type of the pointer was wrong, but at least those are always the same. > > > >Just remove it. > > Andi, > > Have you compiled all of wireless with gcc 4.8? If so, can I assume that > you will report warnings for other drivers?
I did 64bit allyesconfig with LTO yes. wireless has very few warnings overall, compared to many other subsystems.
I found one other issue in it for which I'm sending a patch.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |