Messages in this thread | | | From | "Myklebust, Trond" <> | Subject | Re: [PATCH] Fix memset in NFS zap caches | Date | Mon, 3 Sep 2012 18:52:49 +0000 |
| |
On Mon, 2012-09-03 at 20:47 +0200, Andi Kleen wrote: > > No, this is a gcc bug. > > > > NFS_COOKIEVERF(inode) resolves to an array, so the current code is > > correct. The above change will cause the 2nd half of the array to remain > > uninitialised... > > Are you sure? > > include/linux/nfs_fs.h:268:static inline __be32 *NFS_COOKIEVERF(const struct inode *inode) > > That doesn't look like an array type to me.
Argh... It used to be a #define, but got converted in the commit 99fadcd7646 static inline blitz...
OK, let's just get rid of the NFS_COOKIEVERF thing altogether. At this point it is clearly just obfuscating the code.
-- Trond Myklebust Linux NFS client maintainer
NetApp Trond.Myklebust@netapp.com www.netapp.com
| |