lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 037/218] netconsole: remove a redundant netconsole_target_put()
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Amerigo Wang <amwang@redhat.com>

    commit 72d3eb13b5c0abe7d63efac41f39c5b644c7bbaa upstream.

    This netconsole_target_put() is obviously redundant, and it
    causes a kernel segfault when removing a bridge device which has
    netconsole running on it.

    This is caused by:

    commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093
    Author: Amerigo Wang <amwang@redhat.com>
    Date: Thu May 19 21:39:10 2011 +0000

    netpoll: disable netpoll when enslave a device

    Signed-off-by: Cong Wang <amwang@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/netconsole.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/net/netconsole.c
    +++ b/drivers/net/netconsole.c
    @@ -648,7 +648,6 @@ static int netconsole_netdev_event(struc
    flags);
    dev_put(nt->np.dev);
    nt->np.dev = NULL;
    - netconsole_target_put(nt);
    }
    nt->enabled = 0;
    stopped = true;



    \
     
     \ /
      Last update: 2012-09-28 23:41    [W:4.035 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site