lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 104/127] cpufreq / ACPI: Fix not loading acpi-cpufreq driver regression
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Renninger <trenn@suse.de>

    commit c4686c71a9183f76e3ef59098da5c098748672f6 upstream.

    Commit d640113fe80e45ebd4a5b420b introduced a regression on SMP
    systems where the processor core with ACPI id zero is disabled
    (typically should be the case because of hyperthreading).
    The regression got spread through stable kernels.
    On 3.0.X it got introduced via 3.0.18.

    Such platforms may be rare, but do exist.
    Look out for a disabled processor with acpi_id 0 in dmesg:
    ACPI: LAPIC (acpi_id[0x00] lapic_id[0x10] disabled)

    This problem has been observed on a:
    HP Proliant BL280c G6 blade

    This patch restricts the introduced workaround to platforms
    with nr_cpu_ids <= 1.

    Signed-off-by: Thomas Renninger <trenn@suse.de>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/processor_core.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/acpi/processor_core.c
    +++ b/drivers/acpi/processor_core.c
    @@ -188,10 +188,12 @@ int acpi_get_cpuid(acpi_handle handle, i
    * Processor (CPU3, 0x03, 0x00000410, 0x06) {}
    * }
    *
    - * Ignores apic_id and always return 0 for CPU0's handle.
    + * Ignores apic_id and always returns 0 for the processor
    + * handle with acpi id 0 if nr_cpu_ids is 1.
    + * This should be the case if SMP tables are not found.
    * Return -1 for other CPU's handle.
    */
    - if (acpi_id == 0)
    + if (nr_cpu_ids <= 1 && acpi_id == 0)
    return acpi_id;
    else
    return apic_id;



    \
     
     \ /
      Last update: 2012-09-28 23:41    [W:4.183 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site