lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/57] power: ab8500_bm: Added support for BATT_OVV
On Fri, Sep 28, 2012 at 12:24:53PM -0600, Mathieu Poirier wrote:
[...]
> >> /* Not yet recovered from ovv, reschedule this test */
> >> queue_delayed_work(di->fg_wq, &di->fg_check_hw_failure_work,
> >> - round_jiffies(HZ));
> >> + HZ);
> >
> > Why this change? I.e. round_jiffies(HZ) -> HZ?
> >
> > Yes, it seems like round_jiffies(HZ) is not needed since HZ itself is a
> > full second.. But the change itself does not belong to this patch.
>
> I agree with your point of view. How do we fix it now ? Do you think
> it's worth crafting a one-line patch ?

Yup. Or you can leave the code as is: I guess round_jiffies() is not a big
deal since it's not in some kind of hot path, so generally this doesn't
affect behaviour. It's up to you, I'm fine either way.

Thanks!


\
 
 \ /
  Last update: 2012-09-28 21:01    [W:0.092 / U:1.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site