Messages in this thread | | | Date | Fri, 28 Sep 2012 17:01:34 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 08/16] iommu/amd: Add routines to manage irq remapping tables |
| |
On Fri, Sep 28, 2012 at 10:40:13AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 28, 2012 at 02:23:58PM +0200, Joerg Roedel wrote: > > + irte_info = &cfg->irq_2_iommu; > > + irte_info->sub_handle = devid; > > + irte_info->irte_index = index; > > Should the irte_info also contain the count information to know how > whether the table->table[index] (which would be IRTE_ALLOCATED at > this point) is owned by correct irte_info ?
No, because the irte_info used here is only for the first index. For the following indexes up to index+count-1 other irte_info structs are used. This is necessary because of the way MSI-X interrupts are set up with interrupt remapping.
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |