lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/10] compiler{,-gcc4}.h: Remove duplicate macros
    On Fri, Sep 28, 2012 at 06:20:06PM -0500, Daniel Santos wrote:
    > __linktime_error() does the same thing as __compiletime_error() and is
    > only used in bug.h. Since the macro defines a function attribute that
    > will cause a failure at compile-time (not link-time), it makes more
    > sense to keep __compiletime_error(), which is also neatly mated with
    > __compiletime_warning().
    >
    > Signed-off-by: Daniel Santos <daniel.santos@pobox.com>

    Why not change bug.h in the same commit? Or alternatively, why not
    change it first? Getting rid of __linktime_error *before* changing its
    use in bug.h to __compiletime_error seems wrong.

    - Josh Triplett


    \
     
     \ /
      Last update: 2012-09-29 02:41    [W:4.037 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site