Messages in this thread | | | Date | Fri, 28 Sep 2012 17:23:30 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH 5/10] compiler{,-gcc4}.h: Remove duplicate macros |
| |
On Fri, Sep 28, 2012 at 06:20:06PM -0500, Daniel Santos wrote: > __linktime_error() does the same thing as __compiletime_error() and is > only used in bug.h. Since the macro defines a function attribute that > will cause a failure at compile-time (not link-time), it makes more > sense to keep __compiletime_error(), which is also neatly mated with > __compiletime_warning(). > > Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
Why not change bug.h in the same commit? Or alternatively, why not change it first? Getting rid of __linktime_error *before* changing its use in bug.h to __compiletime_error seems wrong.
- Josh Triplett
| |