Messages in this thread | | | Date | Fri, 28 Sep 2012 10:30:50 +0900 | From | Yasuaki Ishimatsu <> | Subject | Re: [PATCH 2/4] memory-hotplug: add node_device_release |
| |
Hi Kosaki-san,
2012/09/28 10:13, KOSAKI Motohiro wrote: > On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu > <isimatu.yasuaki@jp.fujitsu.com> wrote: >> Hi Kosaki-san, >> >> >> 2012/09/28 5:13, KOSAKI Motohiro wrote: >>> >>> On Thu, Sep 27, 2012 at 1:45 AM, <wency@cn.fujitsu.com> wrote: >>>> >>>> From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >>>> >>>> When calling unregister_node(), the function shows following message at >>>> device_release(). >>> >>> >>> This description doesn't have the "following message". >>> >>> >> >>>> Device 'node2' does not have a release() function, it is broken and must >>>> be >>>> fixed. >> >> >> This is the messages. The message is shown by kobject_cleanup(), when >> calling >> unregister_node(). > > If so, you should quote the message. and don't mix it with your > subject. Moreover > your patch title is too silly. "add node_device_release() function" is > a way. you should > describe the effect of the patch. e.g. suppress "Device 'nodeXX' does > not have a release() function" warning.
What you say is correct. We should update subject and changelog.
> > Moreover, your explanation is still insufficient. Even if > node_device_release() is empty function, we can get rid of the > warning.
I don't understand it. How can we get rid of the warning?
> Why do we need this node_device_release() implementation?
I think that this is a manner of releasing object related kobject.
Thanks, Yasuaki Ishimatsu
| |