lkml.org 
[lkml]   [2012]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] DMA: PL330: Balance module remove function with probe
From
On Thu, Sep 27, 2012 at 9:11 PM, Inderpal Singh
<inderpal.singh@linaro.org> wrote:
> On 27 September 2012 15:18, Vinod Koul <vinod.koul@linux.intel.com> wrote:
>> On Wed, 2012-09-26 at 12:11 +0530, Inderpal Singh wrote:
>>> If we fail pl330_remove while some client is queued, the force unload
>>> will fail and the
>>> force unload will lose its purpose.
>>> How about conditionally DMA_TERMINATE_ALL and free resources like
>>> below ?
>> Why would you want to remove the driver when it is doing something
>> useful? You have to ensure driver is not doing anything.
>>
>> What is point here?
>>
> As mentioned by jassi, if the pl330 module is forced unloaded while
> some client is queued, we have to manually do DMA_TERMINATE_ALL.
>
I meant that in the current situation. Not ideally.

> If failing remove is a better option in case some client is queued, we
> can do away with DMA_TERMINATE_ALL and free_chan_resources and simply
> return a suitable error code from remove.
>
That was exactly what I suggested as an alternative.


\
 
 \ /
  Last update: 2012-09-27 18:41    [W:0.148 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site