Messages in this thread | | | Date | Thu, 27 Sep 2012 12:20:11 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors |
| |
Hi Shuah,
the patch looks better then the older versions. It comes closer to a merge, but I see one issue here:
On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote: > debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr): > Sets dma map error checked status for the dma map entry if one is > found. Decrements the system wide dma_map_errors_not_checked counter > that is incremented by debug_dma_map_page() when it checks for > mapping error before adding it to the dma debug entry table.
It is problematic that the DMA debug code can no longer call dma_mapping_error because of this. How about adding a special version of that function which does no checking and use it in the DMA debug code instead?
Regards,
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |