Messages in this thread | | | Date | Thu, 27 Sep 2012 01:04:26 -0400 | From | Jeff Garzik <> | Subject | Re: [SCSI PATCH] sd: max-retries becomes configurable |
| |
On 09/25/2012 06:38 AM, James Bottomley wrote: > On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: >> Can you be more specific about sysfs location? A runtime-writable (via >> sysfs!) module parameter for a module-wide default seemed appropriate. > > Well, if it's really important, the same thing should happen with > retries as happened with timeout (it became a request_queue property), > but it could be hacked as a struct scsi_disk one with a corresponding > entry in sd_dis_attrs.
Well, it is already a request property... but assigned at initialization from sd-specific code. sd also passes this through scmd->allowed to rq->retries.
It could become a request_queue property, but that seems like a hack as it is simply passed right back into SCSI EH, for SCSI-specific disposition.
Jeff
| |