Messages in this thread | | | Date | Tue, 25 Sep 2012 15:43:20 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 16/19] x86, irq: Introduce setup_remapped_irq() |
| |
On Sun, Aug 26, 2012 at 08:30:30PM +0200, Sebastian Andrzej Siewior wrote: > On Mon, Aug 20, 2012 at 03:56:02PM +0200, Joerg Roedel wrote: > > --- a/arch/x86/include/asm/irq_remapping.h > > +++ b/arch/x86/include/asm/irq_remapping.h > > @@ -44,6 +44,9 @@ extern void compose_remapped_msi_msg(struct pci_dev *pdev, > > struct msi_msg *msg, u8 hpet_id); > > extern int setup_hpet_msi_remapped(unsigned int irq, unsigned int id); > > extern void panic_if_irq_remap(const char *msg); > > +extern bool setup_remapped_irq(int irq, > > + struct irq_cfg *cfg, > > + struct irq_chip *chip); > here and in the next definition, is it possible to fit it in one line or > alteast in two?
It doesn't fit in one line (without violating the 80 column recommendation). So I think this is the best readable alternative format.
> What about > > bool setup_remapped_irq(int irq, struct irq_cfg *cfg, struct irq_chip *chip) > { > if (!irq_remapped(cfg)) > return false; > irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); > irq_remap_modify_chip_defaults(chip); > return true; > }
You are right, that is better. I changed it.
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |