Messages in this thread | | | Date | Mon, 24 Sep 2012 18:36:01 -0500 | From | Ricardo Neri <> | Subject | Re: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine |
| |
Hi Peter, Mark,
On 09/14/2012 07:05 AM, Peter Ujfalusi wrote: > Hello, > > Changes since v2: > - As it has been discussed the no_wakeup parameter has been replaced with flags > for the dmaengine APIs > > Changes since v1: > - Support for pause/resume for OMAP audio via dmaengine > - dmaengine: support for NO_PERIOD_WAKEUP in cyclic mode > - OMAP to keep supporting NO_PERIOD_WAKEUP for audio > - Other plaforms can also try to enable this mode since we have now generic > interface to do so. > > This series will switch the OMAP audio to use dmaengine. > The final patch which does the switch was based on Russell King's earlier patch. > > The first 10 patch is to prepare the OMAP audio drivers for a smooth change to > dmaengine: > - sDMA FRAME sync mode is removed and replaced with PACKET mode > - dai drivers no longer need to configure sDMA sync mode > - dai drivers does not need to specify the DMA word length - with the exception > of the omap-hdmi driver which requires 32bit word length regardless of the > audio format in use > - the McPDM driver used (to my surprise) hackish way of getting the DMA channel > and address - via defines from some header files > > After the conversion OMAP audio support should have the same features as before, > no regressions expected. > > I have tested the series on: > - BeagleBoard (audio via McBSP): > - aplay/arecord. In element mode and in threshold mode with different period > sizes > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > - OMAP4 Blaze (audio via McPDM and DMIC) > - aplay/arecord > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > > The patches has been generated against: > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7 > > Janusz: Can you retest this series on OMAP1 to be sure I have not broken it? > Ricardo: Can you test the omap-hmdi if it is still working?
I tested these changes from Mark's for-3.7 branch. HDMI audio is working fine after applying patch 03. Such patch is missing in Mark's branch and this causes a build break with omap2plus_defconfig. Not sure if this is expected, Most likely not.
Tested-by: Ricardo Neri <ricardo.neri@ti.com>
Ricardo
| |