Messages in this thread | | | Date | Mon, 24 Sep 2012 15:04:04 -0400 | From | Jason Baron <> | Subject | Re: [PATCH 5/6] dyndbg: in dynamic_emit_prefix, change inter-field separator |
| |
On Tue, Sep 18, 2012 at 07:56:42PM -0700, Joe Perches wrote: > On Tue, 2012-09-18 at 17:36 -0600, Jim Cromie wrote: > > dynamic_emit_prefix() currently separates modname, funcname, lineno > > with ':'. This is confounds use of cut -d: <logfile>, since the field > > positions can change per callsite with dynamic-debug. So change > > inter-field separator to '.' and keep the ':' prefix terminator. > > > > This improves the situation, but doesnt solve it entirely; if > > dyndbg==p is used instead of dyndbg==p[fmlt]+, the callsite is enabled > > but no prefix is added, so theres one less ':' in the message. > > Changing the terminator to ',' would fix this, and might be warranted, > > especially since pr_fmt() typically adds a ':' as well. > > > > Joe Perches wasnt a fan of this, but his complaint was essentially > > that cut -d: was a poor way to do this kind of thing. I concede that > > point, but note that the kernel is not in the habit of needlessly > > confounding users work, at least when accommodating them is so trivial. > > And I still think this is ugly as it requires different parsing > by scripts when using combinations of +pfmlt > >
If this patch doesn't 'solve it entirely', I'm reluctant to ack it, Would brackets, such as {} around the optional prefix be reasonable?
Thanks,
-Jason
| |