Messages in this thread | | | From | Miklos Szeredi <> | Subject | Re: [PATCH 0/2] struct pid-ify autofs4 | Date | Mon, 24 Sep 2012 15:34:32 +0200 |
| |
Ian Kent <raven@themaw.net> writes:
> On Fri, 2012-09-21 at 17:44 +0200, Miklos Szeredi wrote: >> Miklos Szeredi <miklos@szeredi.hu> writes: >> >> > These two patches change autofs4 to store struct pid pointers instead of pid_t >> > values. >> > >> > Fixed various issues with the previous post. Not tested, handle with >> > care! >> >> Customer gave positive test results. > > For what exactly, there's no problem description in these patches?
From what I understand (and I'm not an expert by any means) is that autofs doesn't work if containers are used. The first patch fixes this.
Both the patches replace pid_t with a refcounted struct pid object, which has better lifetime properties: you don't know whether a pid_t is valid, because pid numbers are reused, while pid objects remain valid until there are no more references to them.
Thanks, Miklos
| |