Messages in this thread | | | From | Hans Verkuil <> | Subject | Re: [PATCH v5] media: v4l2-ctrl: add a helper function to add standard control with driver specific menu | Date | Mon, 24 Sep 2012 14:58:14 +0200 |
| |
On Mon September 24 2012 14:53:40 Prabhakar wrote: > From: Lad, Prabhakar <prabhakar.lad@ti.com> > > Add helper function v4l2_ctrl_new_std_menu_items(), which adds > a standard menu control, with driver specific menu.
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com> > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com> > Cc: Hans Verkuil <hans.verkuil@cisco.com> > Cc: Sakari Ailus <sakari.ailus@iki.fi> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > Cc: Rob Landley <rob@landley.net> > --- > Changes for v5: > 1: Fixed some grammatical issues pointed by Hans. > > Changes for v4: > 1: Rather then adding a function to modify the menu, added a helper > function, that creates a new standard control with user specific > menu. > > Changes for v3: > 1: Fixed style/grammer issues as pointed by Hans. > Thanks Hans for providing the description. > > Changes for v2: > 1: Fixed review comments from Hans, to have return type as > void, add WARN_ON() for fail conditions, allow this fucntion > to modify the menu of custom controls. > > Documentation/video4linux/v4l2-controls.txt | 24 +++++++++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 30 +++++++++++++++++++++++++++ > include/media/v4l2-ctrls.h | 23 ++++++++++++++++++++ > 3 files changed, 77 insertions(+), 0 deletions(-)
| |