Messages in this thread Patch in this message | | | Date | Fri, 21 Sep 2012 12:58:25 -0700 | From | "tip-bot for H. Peter Anvin" <> | Subject | [tip:x86/smap] x86-32, mm: The WP test should be done on a kernel page |
| |
Commit-ID: 8bd753be7a96443dd5111cb07ed5907a3787c978 Gitweb: http://git.kernel.org/tip/8bd753be7a96443dd5111cb07ed5907a3787c978 Author: H. Peter Anvin <hpa@linux.intel.com> AuthorDate: Fri, 21 Sep 2012 12:43:06 -0700 Committer: H. Peter Anvin <hpa@linux.intel.com> CommitDate: Fri, 21 Sep 2012 12:45:25 -0700
x86-32, mm: The WP test should be done on a kernel page
PAGE_READONLY includes user permission, but this is a page used exclusively by the kernel; use PAGE_KERNEL_RO instead.
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> Link: http://lkml.kernel.org/r/1348256595-29119-3-git-send-email-hpa@linux.intel.com --- arch/x86/mm/init_32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c index 575d86f..e537b35 100644 --- a/arch/x86/mm/init_32.c +++ b/arch/x86/mm/init_32.c @@ -712,7 +712,7 @@ static void __init test_wp_bit(void) "Checking if this processor honours the WP bit even in supervisor mode..."); /* Any page-aligned address will do, the test is non-destructive */ - __set_fixmap(FIX_WP_TEST, __pa(&swapper_pg_dir), PAGE_READONLY); + __set_fixmap(FIX_WP_TEST, __pa(&swapper_pg_dir), PAGE_KERNEL_RO); boot_cpu_data.wp_works_ok = do_test_wp_bit(); clear_fixmap(FIX_WP_TEST);
| |