Messages in this thread | | | Date | Fri, 21 Sep 2012 19:41:07 +0300 | From | Kalle Valo <> | Subject | Re: [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable_scatter |
| |
On 09/03/2012 11:15 PM, Andi Kleen wrote: > gcc 4.8 warns > > /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c: > In function 'ath6kl_sdio_enable_scatter': > /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:748:16: > warning: 'ret' may be used uninitialized in this function > [-Wmaybe-uninitialized] > if (virt_scat || ret) { > ^ > > The variable can indeed be uninitialized when the previous if branch is > skipped. I just set it to zero for now. I'm not fully sure the fix is > correct, maybe the || should be an && ?
From a quick look || should be correct, but of course I might be missing something. I think your patch is correct way to fix this.
Thanks, applied to ath6kl.git. I just added "ath6kl:" prefix to the title.
Kalle
| |