lkml.org 
[lkml]   [2012]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/6] xen-netfront: handle backend CLOSED without CLOSING
    Date
    From: David Vrabel <david.vrabel@citrix.com>

    Backend drivers shouldn't transistion to CLOSED unless the frontend is
    CLOSED. If a backend does transition to CLOSED too soon then the
    frontend may not see the CLOSING state and will not properly shutdown.

    So, treat an unexpected backend CLOSED state the same as CLOSING.

    Signed-off-by: David Vrabel <david.vrabel@citrix.com>
    Cc: Ian Campbell <ian.campbell@citrix.com>
    Cc: <netdev@vger.kernel.org>
    ---
    drivers/net/xen-netfront.c | 5 ++++-
    1 files changed, 4 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
    index 3089990..843533a 100644
    --- a/drivers/net/xen-netfront.c
    +++ b/drivers/net/xen-netfront.c
    @@ -1719,7 +1719,6 @@ static void netback_changed(struct xenbus_device *dev,
    case XenbusStateReconfiguring:
    case XenbusStateReconfigured:
    case XenbusStateUnknown:
    - case XenbusStateClosed:
    break;

    case XenbusStateInitWait:
    @@ -1734,6 +1733,10 @@ static void netback_changed(struct xenbus_device *dev,
    netif_notify_peers(netdev);
    break;

    + case XenbusStateClosed:
    + if (dev->state == XenbusStateClosed)
    + break;
    + /* Missed the backend's CLOSING state -- fallthrough */
    case XenbusStateClosing:
    xenbus_frontend_closed(dev);
    break;
    --
    1.7.2.5


    \
     
     \ /
      Last update: 2012-09-21 19:01    [W:4.111 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site