Messages in this thread | | | Date | Fri, 21 Sep 2012 13:47:15 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 4/4] mm: remove free_page_mlock |
| |
On Tue, Sep 18, 2012 at 08:57:27PM -0700, Hugh Dickins wrote: > We should not be seeing non-0 unevictable_pgs_mlockfreed any longer. > So remove free_page_mlock() from the page freeing paths: __PG_MLOCKED > is already in PAGE_FLAGS_CHECK_AT_FREE, so free_pages_check() will now > be checking it, reporting "BUG: Bad page state" if it's ever found set. > Comment UNEVICTABLE_MLOCKFREED and unevictable_pgs_mlockfreed always 0. > > Signed-off-by: Hugh Dickins <hughd@google.com> > Cc: Mel Gorman <mel@csn.ul.ie> > Cc: Rik van Riel <riel@redhat.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michel Lespinasse <walken@google.com> > Cc: Ying Han <yinghan@google.com>
Like Johannes I think you should just drop the counter. I find it very unlikely that there is a tool that depends on it existing because it's very hard to draw any useful conclusions from its value unlikes like say pgscan* or pgfault.
Acked-by: Mel Gorman <mel@csn.ul.ie>
Thanks Hugh.
-- Mel Gorman SUSE Labs
| |