lkml.org 
[lkml]   [2012]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver
> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Friday, September 21, 2012 3:07 PM
> To: Venu Byravarasu
> Cc: gregkh@linuxfoundation.org; balbi@ti.com; Stephen Warren; linux-
> kernel@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> tegra@vger.kernel.org; Stephen Warren; stern@rowland.harvard.edu
> Subject: Re: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver
>
> * PGP Signed by an unknown key
>
> Hi,
>
> On Thu, Sep 20, 2012 at 05:32:36PM +0530, Venu Byravarasu wrote:
> > Thanks Greg, for quick response.
>
> I'm waiting for a newer version fixing Kishon's comments.

As I mentioned in reply to his comments, most of the patch is
dealing with re-organizing the code. Hence kept the cleaning
part aside for next patch.

> BTW, his comment about pdata usage is 100% valid. You should fix that.
>

Are you referring to below comments:

It's better you have the below code under *if (np)*, since both device
node and pdata co-exist for you.
> + phy_type = of_property_match_string(np, "phy_type", "utmi");
> + if (phy_type >= 0)

If so, I can address it and push an updated patch with that.

> --
> balbi
>
> * Unknown Key
> * 0x35CAA444


\
 
 \ /
  Last update: 2012-09-21 14:41    [W:0.034 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site